Allow overriding Airtable base IDs via env vars#307
Open
ankit0504 wants to merge 1 commit intoLanguage-Mapping:masterfrom
Open
Allow overriding Airtable base IDs via env vars#307ankit0504 wants to merge 1 commit intoLanguage-Mapping:masterfrom
ankit0504 wants to merge 1 commit intoLanguage-Mapping:masterfrom
Conversation
Introduce REACT_APP_AIRTABLE_BASE and REACT_APP_AIRTABLE_CENSUS_BASE env vars with the existing ELA production IDs as fallbacks. The upstream ELA Airtable bases are private, so contributors without access cannot run the app locally against real data. With this change they can duplicate the schema into their own workspace and point the local dev build at it via .env, while the default behavior for anyone with access to the ELA bases is unchanged. Also document the two new vars in sample.env.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues resolved by this pull request
None — quality-of-life change for contributors who don't have access to the upstream ELA Airtable bases.
This PR is independent of the in-flight upgrade stack (#304, #305, #306). It targets `master` and can land in any order relative to those.
Prerequisites
Review type
What's in this PR
Motivation
The project README already warns: "Your setup will need to match ours, or you'll want to edit the code to your needs." This removes the "edit the code" friction — contributors without ELA base access can now run the app locally against their own duplicated base without making a local-only code change to `api.ts` that has to be stashed before every push.
Verification done locally
What to review